search

isort / isort-action

Github Action to run isort
MIT License
22 stars 14 forks source link

Add test cases for problem matcher logic #67

Open jamescurtin opened 1 year ago

jamescurtin commented 1 year ago 
    > This looks great!

Thanks.

Do you think it would be possible to add a job to the test workflow that asserts the regex in isort-matcher.json matches against an expected file?

Could we compromise on merging this as is and creating an issue in the project assigned to me, then I'll try and do a more general helper action to test problem matchers, as the point you raise is valid for the others I use elsewhere too?

If isort's error message ever changed, this should be sufficient to let us know an additional pattern would need to be added.

If it was ever going to be changed, it would be beneficial to encourage them to add a separator between the filename and the error message, especially if they started to add additional error messages in future...

Originally posted by @peternewman in https://github.com/isort/isort-action/issues/66#issuecomment-1339510399

jamescurtin commented 1 year ago

FYI @peternewman; Doesn't seem like I can assign you.

peternewman commented 1 year ago

FYI @peternewman; Doesn't seem like I can assign you.

That was my plan all along! Mwahahaha!

More seriously, I think you just need to make people members of the org with read access to the repo to be able to assign them, that works for me on another org. I have a secret team called foo-contributors and add people to that.

Although maybe having replied to this issue will be sufficient now? Again it seems like it from past experience, unless it's the issue reporter that's the required state.