leetload fails because of unicode filenames

isotoma / leetveld

Django hosted private rietveld for code review

5 stars 0 forks source link

leetload fails because of unicode filenames #15

Closed karenc closed 13 years ago

karenc commented 14 years ago

svn: Error converting entry in directory 'launchinabox/site/tests/data' to UTF-8 svn: Can't convert string from native encoding to 'UTF-8': svn: ?\227?\131?\134?\227?\130?\185?\227?\131?\136.jpg

error code 1 Got error status from ['svn', 'status', '--ignore-externals']:

Files in launchinabox/site/tests/data: isotoma_logo.gif isotoma.png テスト.jpg 名前.zip

karenc commented 14 years ago

Got around the problem by "rm -rf launchinabox/site/tests/data" before running leetload

bne commented 13 years ago

This looks like it's to do with encoding and Popen in RunShellWithReturnCode of upload.py (around about here: https://github.com/isotoma/leetveld/blob/master/src/codereview/static/upload.py#L601)

Running "svn status" on the CL, obviously doesn't asplode. Running it through Popen does

bne commented 13 years ago

Closed in fb8d40e The env var LC_ALL was being explicitly set to 'C' rather than inheriting the locale from the host environment.