Problem with "Bad content" after uploading patch

isotoma / leetveld

Django hosted private rietveld for code review

5 stars 0 forks source link

Problem with "Bad content" after uploading patch #18

Closed karenc closed 13 years ago

karenc commented 14 years ago

revisions 22468:22470

bne commented 13 years ago

This appears to start with an "old chunk mismatch" error displayed inline. A flag is then set against the content record "is_bad" and next time the page is loaded, the bad content error appears.

bne commented 13 years ago

Checks for empty old chunk before marking content as bad, tentatively closed by aa0d7f2cc0ac4c843f444b854358e919bd3dcc7c

bne commented 13 years ago

Check was crapping out if the diff didn't have a previous entry (ie, it was a new addition). A check is now done before marking as bad content, but the existing patches won't be fixed sadly.

karenc commented 13 years ago

Cool!!! Good job debugging it. Thanks very much!