search

isotoma / leetveld

Django hosted private rietveld for code review
5 stars 0 forks source link

Notification emails have lots of "None" in the recipients lists #4

Closed tomds closed 13 years ago

tomds commented 14 years ago

Here is what Thunderbird shows me for the average email received from leetveld:

From: matt.hall@isotoma.com Reply-To: matt.hall@isotoma.com, tom.desimone@isotoma.com, richard.mitchell@isotoma.com, chris.clarke@isotoma.com, None To: tom.desimone@isotoma.com, richard.mitchell@isotoma.com, chris.clarke@isotoma.com CC: None

What are those "None"s doing there?

I went to look at the raw email headers, and they are exactly the same as above i.e. it is deliberately inserting "None" into the headers.

1stvamp commented 14 years ago

See #14 for possible fix.

bne commented 13 years ago

Turns out it was writing the string 'None' if django_settings.RIETVELD_INCOMING_MAIL_ADDRESS was empty, closed in 52726f3