search

isotoma / leetveld

Django hosted private rietveld for code review
5 stars 0 forks source link

Problems with leetloading directories #8

Closed mitchellrj closed 14 years ago

mitchellrj commented 14 years ago

Loading a newly added directory from a working copy does not load the new files into the web interface.

Attempting to load a newly added directory using --rev n-1:n throws an error.

mitchellrj commented 14 years ago

This is partly a duplicate of #2

karenc commented 14 years ago

The problem is copying files (svn cp) in the commit. If you just add a file, leetload can detect it because it's in svn diff. But if you copy a file, even though you're also adding a file, leetload can't detect it because it's not in svn diff.

copied files can be identified by: (in the output of svn status) A + src/customizations/italy/settings

added files are like this: A init.py

Will see if it's easy to fix.

karenc commented 14 years ago

Working on it at the moment. Got a fix for uploading the svn cp'd files, but the file content shows up twice in the side-by-side-diff view

karenc commented 14 years ago

This has been fixed in issue 12

bne commented 14 years ago

merged and released in 0.5