search

isotoma / leetveld

Django hosted private rietveld for code review
5 stars 0 forks source link

Fix post-commit upload.py failing with new directory (issue 2) #9

Closed karenc closed 14 years ago

karenc commented 14 years ago

The problem before was, the script tries to get the status (whether it was "A" added, "M" modified, or "D" deleted) of a file by "svn ls" the parent directory before the commit and after the commit. The parent directory didn't exist before the commit (since it's added in the commit), so "svn ls" fails...

I've fixed the problem by completely changing the implementation of get status. I'm now analyzing the output of "svn log -v". It gives you the status of every file in the commit. It is only slightly complicated when there are multiple revisions.

I've added some unit tests for the parts I've added or changed. Please have a look.

karenc commented 14 years ago

See issue 12

bne commented 14 years ago

merged and released in 0.5