search

isotoma / react-cognito

Library for integrating Facebook React and Amazon Cognito
Apache License 2.0
116 stars 48 forks source link

Fix issue #5 using aws-sdk instead of aws-cognito-sdk #11

Closed nokrosis closed 6 years ago

nokrosis commented 7 years ago

This changes fixed issue #5 for me when trying to build modules with webpack

nokrosis commented 7 years ago

Is there an alternative solution? Or what is missing/wrong on my PR to get merged?

kbrown commented 7 years ago

aws-sdk is fat compared to aws-cognito-sdk, but for me for now is worth it for just working.

nokrosis commented 7 years ago

It looks like aws-sdk/lib/core is enough since it exports CognitoIdentityCredentials, but I don't know how to update it correctly since making that change and building the library, increases the final size of react-cognito.min.js.

If anyone could help...