search

isotope / core

Core repository of Isotope eCommerce, an eCommerce extension for Contao Open Source CMS
https://isotopeecommerce.org
135 stars 107 forks source link

shipping group with group item label #1543

Open cs1982 opened 8 years ago

cs1982 commented 8 years ago

If using a shipping group, in shipping calculator and cart the label ("Bezeichnung") or if null the name is shown. I think, it would provide us the capability to work more accurate, when the following mode is implemented:

If using the group calculation mode "lowest price", "highest price" and "first price" (only one member of the group causes the shipping price) use the first not null value: group member label - group label - group member name - group name. So you can show different shipping labels in dependencie of the picked group member. The result of these approach is the same like the actual practice, if the labels of the group members are null.

When using the group calculation mode "sum of parial prices" the acutual approach fits fine: group label - group name.

aschempp commented 8 years ago

Would make sense, but it's an incompatible change…

cs1982 commented 8 years ago

Would you explain, where the incompatiblity is? I can not recognize it. Thanks!

aschempp commented 8 years ago

Well the label determination is currently different. That means if we apply the changes the label will change on some installations without notice.

cs1982 commented 8 years ago

Mh. I thought about this topic again. Yesterday I brought the migration from Isotope 1.4.7 to 2.3.1 behind my. Nothing can scare me ;-) With the behavior "take first not null from: group member label - group label - group member name - group name" we can achive the same result as now, when 'group label' contains the 'group name'. Or? Thanks for review.