search

isotope / core

Core repository of Isotope eCommerce, an eCommerce extension for Contao Open Source CMS
https://isotopeecommerce.org
135 stars 107 forks source link

Watermark is not applied to srcset #2404

Open cboelter opened 1 year ago

cboelter commented 1 year ago

I'm trying to use the watermark function inside the galleries but this is not working if the attribute srcset is set. At the moment isotope only generates a watermarked image for the attribute src: https://github.com/isotope/core/blob/2.8/system/modules/isotope/library/Isotope/Model/Gallery/Standard.php#L386 I think there should be also a handling for the srcsetotherwise for this attribute the original images are used.

If you agree I will be able to create a pull request. My approach would be to split the comma separated list of sources and change the image path with the watermarked path.

aschempp commented 1 year ago

Shouldn't it be possible to access the list of images before the string is created? Maybe we can influence the image creation directly through the "new" Image methods

cboelter commented 1 year ago

I talked to my customer and he deciced to not use the watermark at the moment. If he changed I will able to work on the watermark again.