search

isotope / core

Core repository of Isotope eCommerce, an eCommerce extension for Contao Open Source CMS
https://isotopeecommerce.org
136 stars 107 forks source link

Add optional setting to prevent force-show first order column in backend #2527

Closed ameotoko closed 1 month ago

ameotoko commented 4 months ago

This ports https://github.com/contao/contao/pull/6593 to Isotope's data container driver.

aschempp commented 3 months ago

Can you please rebase this to the 2.9 branch? There are no plans to add more fixes to 2.8, and I think I have updated the driver for Contao 4.13 already (not sure if that is in there though).

ameotoko commented 3 months ago

When will 2.9 be released then? Isotope always lacks compatibility with 4.13. I already accepted that I don't have to learn Contao 5 for a long time, but support for 4.13 should be ongoing IMO.

fritzmg commented 3 months ago

Both Isotope 2.8 and 2.9 are compatible with Contao 4.13.

ameotoko commented 3 months ago

By "compatibility" I meant, that Isotope should not discard core's features when extending from Contao's core driver. This is currently the case in 2.8 with this issue and #2341 for example.

fritzmg commented 3 months ago

Yes, but there won't be another 2.8 release, hence you should rebase this against 2.9.

ameotoko commented 3 months ago

I'm a little confused now... So, if I found another bug (which I just did), I should submit the fix against 2.9? But it means, I should be using 2.9 in production then? But it hasn't been released, it feels weird to use a dev branch in production, hence my question... Can you help me understand the process?

aschempp commented 1 month ago

Thank you @ameotoko. I merged this into 2.9 now