search

isotope / core

Core repository of Isotope eCommerce, an eCommerce extension for Contao Open Source CMS
https://isotopeecommerce.org
135 stars 107 forks source link

Evaluations & statistics #2536

Open katgirl opened 1 month ago

katgirl commented 1 month ago

Isotope Version 2.9.0

For sales statistics image

but at Sales summary image

The number of products is the number of units. The sum of sales and the resulting average is also incorrect

katgirl commented 1 month ago

The Problem is:

https://github.com/isotope/core/blob/2.9/system/modules/isotope_reports/library/Isotope/BackendModule/Reports.php#L150C24-L165C44

The LEFT JOIN at tl_iso_product_collection_item generate duplicate content by order.

aschempp commented 3 weeks ago

@error08 could you help with this and tell if https://github.com/isotope/core/pull/2537 is the correct fix for your new statistics?

error08 commented 3 weeks ago

Hi @aschempp and @katgirl, if I understand it right, I would it solve this way: #2542. @katgirl: Your fix, sums the quantity of the items, but here we want display the products, right?

error08 commented 3 weeks ago

@katgirl The sales total here are the tax free value of the all paid orders in the time range minus the discounts. I will double check that next week.

aschempp commented 3 weeks ago

but here we want display the products, right?

If I understand correctly, we're not sure we want to show the number of "different products", or the number of quantities? Personally (I'm not a shop owner!) I would expect the number of items here, the number of things I will pack into my shipping boxes.

@katgirl did your statement about incorrect resulting average include net or gross prices?

aschempp commented 3 weeks ago

Maybe we should name the columns "Net Sales Total" and "Net Sales ø" if that would make it more obvious?

aschempp commented 4 days ago

Any opinions on the matter?

error08 commented 2 days ago

I'm fine with "Net Sales Total" and "Net Sales ø". Regarding the issue, I will try to test it this weekend.

error08 commented 1 day ago

@aschempp , @katgirl : I have found the bug, please double check the PR 2542