isoverse / isoorbi

https://www.isoverse.org/isoorbi
Other
3 stars 1 forks source link

Update check on typo #49

Closed JanMarvin closed 1 month ago

JanMarvin commented 3 months ago

Hi,

your check here

https://github.com/isoverse/isoorbi/blob/cd3a20be061a9cf782d921376acd2745eda4c34a/tests/testthat/test_export_functions.R#L44-L46

checks for a string with a typo. This was fixed in openxlsx a while ago. We ran a revdep to prepare a new release and this came up. Could you please adjust this check to test for something else?

This is related to https://github.com/ycphs/openxlsx/issues/476

JanMarvin commented 1 month ago

Fixed in https://github.com/isoverse/isoorbi/commit/7838163ee4f97cc50015738de5fd789b8fe773b7