Closed citizenlee closed 7 years ago
Hmm strange...can you try using a newer compiler and letting me know how it works? For me it works well on g++ 6.2 on several machines.
Best regards, Ivan.
Will try this on a different computer. The above was run on an Amazon AMI.
I am having the same problem with g++ version 4.8.4 on ubuntu 14.04 It does work if g++ 6 is used after installing g++ 6.
Using brew to install gcc 6.1 without multilib (for openmp), I get the following compilation failure:
Makefile:100: " WARNING g++ minor version <7 " mkdir -p obj_linux/codebase/gindex/src/minimizer_index/ g++ -static-libgcc -static-libstdc++ -D__cplusplus=201103L -I"./src/" -I"/usr/include/" -I"codebase/seqlib/src/libs/seqan-library-2.0.1/include" -I"codebase/seqlib/src/libs/libdivsufsort-2.0.1-64bit/" -Icodebase/argumentparser/src -Icodebase/gindex/src -Icodebase/seqlib/src -DRELEASE_VERSION -O3 -fdata-sections -ffunction-sections -c -fmessage-length=0 -ffreestanding -fopenmp -m64 -std=c++11 -Werror=return-type -pthread -o obj_linux/codebase/gindex/src/minimizer_index/minimizer_index.o codebase/gindex/src/minimizer_index/minimizer_index.cc codebase/gindex/src/minimizer_index/minimizer_index.cc:2:26: error: expected constructor, destructor, or type conversion before '.' token
I was able to compile on Amazon Ubuntu 16.04 (ami-f4cc1de2) after installing gcc/g++/zlib1g-dev
Hi all, thank you for reporting back!
It seems there was an important change between C++11 and C++14 standards: http://stackoverflow.com/questions/35906268/returning-local-unique-ptr-as-a-shared-ptr .
In the commit you tested I implicitly converted from std::unique_ptr to std::shared_ptr, which older versions of g++ could not handle.
I fixed this in the latest commit (about 15mins ago) and tested on g++ 4.8.4 and it seems to work.
Would it be possible for any of you to verify the fix?
Thank you, Best regards, Ivan.
Latest commit did compile for me with g++ 4.8.3 on Amazon Linux AMI. Running a clang error - unsupported option '-fopenmp' on my mac - will work on this more. Thanks Ivan!
Hi Henry! Thank you for testing and reporting back! Glad to hear it works on older compilers now. As for clang, from what I hear (I'm not a Mac user) it does not have a support for OpenMP for some reason...
Thanks again! Best regards, Ivan.
Hey isovic, I was also able to compile on g++ 4 on ubuntu 14.04. Thanks for the replies! Tim
Hey Tim! Great to hear - thanks for reporting!
Best regards, Ivan.
Ran into the following compile error below: