search

ispapp / ispapp-routeros-client

The Official ISPApp Client for RouterOS
MIT License
8 stars 5 forks source link

Removed ispapp-lan, dhcp-server, ip firewall nat masquerade, interface bridge port and hidden SSIDs. #61

Closed emrahtavsan closed 1 year ago

emrahtavsan commented 1 year ago

Remove these parts of the RouterOS client script: virtual access points, hidden SSIDs, interface bridge ispapp-lan, interface bridge port, ip address 10.10.0.1/16, ip dhcp-server, ip dhcp-server network, ip pool ispapp-lan-pool, ip firewall nat masquerade.

andrewhodel commented 1 year ago

It does not:

  1. remove the existing ispapp-wifi bridge
  2. remove the existing ispapp-lan bridge
  3. remove the existing ispapp-lan pool
  4. remove the existing ispapp dhcp server
  5. remove the existing interface bridge ports of the wireless interfaces
  6. remove the existing security profile

While it continues to create:

  1. ispapp-ipv6-disable.rsc
  2. ispapp-ipv6-enable.rsc
mthoodlum commented 1 year ago

It doesn't need to remove the existing settings. Those can all be safely and deliberately removed with bulk commands.

mthoodlum commented 1 year ago

@emrahtavsan would you please also remove the IPv6 enable/disable functionality?

mthoodlum commented 1 year ago

@andrewhodel, why hasn't this pull request been accepted? Even if it is incomplete, the current changes still need to be accepted.

andrewhodel commented 1 year ago

You say it doesn't need to remove the existing settings, but it does remove an existing setting and it doesn't make sense to not do it all correctly.

Screenshot 2022-11-30 at 8 59 15 AM
andrewhodel commented 1 year ago

This also does not support more than one ssid.

There is no way that the virtual interfaces can be placed in a bridge when the ispapp-lan bridge is removed.

Removing this functionality breaks multiple ssid support using the host wireless configurations.