ispapp / ispapp-routeros-client

The Official ISPApp Client for RouterOS
MIT License
8 stars 4 forks source link

ispapp-routeros-client is updated. #68

Closed emrahtavsan closed 1 year ago

emrahtavsan commented 1 year ago

Serial Number, Current Firmware and Model Number added. OSVersion updated. Version is set to "RouterOS-v2.27"

andrewhodel commented 1 year ago

This fails to work on RouterOS v6.48.6 with this error input does not match any value of value-name for both serial-number and model.

andrewhodel commented 1 year ago

That failure is on a CHR (x86_64).

andrewhodel commented 1 year ago

Here's some output from hosts on demo showing that these values are not available on CHR routers but are available on other routers and versions.

This is why we have the ability to test many routers at once with bulk commands.

CHR-Virginia-1
+147550ms
/system routerboard print
+200828ms (Mon Jan 09 2023 16:06:25 GMT+1000 (Vladivostok Standard Time))
  routerboard: no

iulian-hac-ax2
+147551ms
/system routerboard print
+208693ms (Mon Jan 09 2023 16:06:33 GMT+1000 (Vladivostok Standard Time))
       routerboard: yes
        board-name: hAP ax^2
             model: C52iG-5HaxD2HaxD
     serial-number: HD70836EKXP
     firmware-type: ipq6000
  factory-firmware: 7.5
  current-firmware: 7.6
  upgrade-firmware: 7.6

lab-ROSv6-750UP
+147552ms
/system routerboard print
+206851ms (Mon Jan 09 2023 16:06:31 GMT+1000 (Vladivostok Standard Time))
       routerboard: yes
             model: 750UP
     serial-number: 4C9904C9CDC9
     firmware-type: ar7240
  factory-firmware: 3.10
  current-firmware: 6.47.9
  upgrade-firmware: 6.49.7

lab-ROSv6-951G-2HnD
+147553ms
/system routerboard print
+156688ms (Mon Jan 09 2023 16:05:41 GMT+1000 (Vladivostok Standard Time))
       routerboard: yes
             model: 951G-2HnD
     serial-number: 642F061CFCC1
     firmware-type: ar9344
  factory-firmware: 3.33
  current-firmware: 6.47.10
  upgrade-firmware: 6.49.7

lab-ROSv6-HEX-POE
+147554ms
/system routerboard print
+154640ms (Mon Jan 09 2023 16:05:39 GMT+1000 (Vladivostok Standard Time))
       routerboard: yes
        board-name: hEX PoE
             model: 960PGS
     serial-number: AD8C0A4BBD93
     firmware-type: qca9550L
  factory-firmware: 6.42.12
  current-firmware: 6.49.7
  upgrade-firmware: 6.49.7

lab-ROSv6-cAP-AC
+147555ms
/system routerboard print
+150956ms (Mon Jan 09 2023 16:05:35 GMT+1000 (Vladivostok Standard Time))
       routerboard: yes
        board-name: cAP ac
             model: RouterBOARD cAP Gi-5acD2nD
          revision: US
     serial-number: ADCE0A90EDE9
     firmware-type: ipq4000L
  factory-firmware: 6.42.11
  current-firmware: 6.46.7
  upgrade-firmware: 6.49.7

lab-ROSv6-hAP-AC
+147556ms
/system routerboard print
+171437ms (Mon Jan 09 2023 16:05:56 GMT+1000 (Vladivostok Standard Time))
       routerboard: yes
        board-name: hAP ac
             model: RouterBOARD 962UiGS-5HacT2HnT
     serial-number: 830908B5A8A1
     firmware-type: qca9550L
  factory-firmware: 3.41
  current-firmware: 6.48.6
  upgrade-firmware: 6.49.7

lab-ROSv6-hAP-AC2
+147557ms
/system routerboard print
+206244ms (Mon Jan 09 2023 16:06:31 GMT+1000 (Vladivostok Standard Time))
       routerboard: yes
        board-name: hAP ac^2
             model: RBD52G-5HacD2HnD
          revision: r3
     serial-number: F6530FD1119D
     firmware-type: ipq4000L
  factory-firmware: 6.48.6
  current-firmware: 6.48.6
  upgrade-firmware: 6.49.7

lab-ROSv6-hEX-PoE-lite
+147558ms
/system routerboard print
+183824ms (Mon Jan 09 2023 16:06:08 GMT+1000 (Vladivostok Standard Time))
       routerboard: yes
        board-name: hEX PoE lite
             model: RouterBOARD 750UP r2
     serial-number: 72C007313523
     firmware-type: qca9531L
  factory-firmware: 3.36
  current-firmware: 3.36
  upgrade-firmware: 6.49.7

lab-ROSv7-cAP-AC
+147559ms
/system routerboard print
+158020ms (Mon Jan 09 2023 16:05:42 GMT+1000 (Vladivostok Standard Time))
       routerboard: yes
        board-name: cAP ac
             model: RBcAPGi-5acD2nD
          revision: US
     serial-number: ADCE0AA1DE41
     firmware-type: ipq4000L
  factory-firmware: 6.42.11
  current-firmware: 6.46.8
  upgrade-firmware: 7.6

lab-ROSv7-hAP-AC
+147559ms
/system routerboard print
+153103ms (Mon Jan 09 2023 16:05:37 GMT+1000 (Vladivostok Standard Time))
       routerboard: yes
        board-name: hAP ac
             model: RouterBOARD 962UiGS-5HacT2HnT
     serial-number: 8A7D080E3191
     firmware-type: qca9550L
  factory-firmware: 3.41
  current-firmware: 6.49
  upgrade-firmware: 7.5

lab-ROSv7-hAP-AC-Lite
+147560ms
/system routerboard print
+186691ms (Mon Jan 09 2023 16:06:11 GMT+1000 (Vladivostok Standard Time))
       routerboard: yes
        board-name: hAP ac lite
             model: RB952Ui-5ac2nD
     serial-number: C5600D562E46
     firmware-type: qca9531L
  factory-firmware: 6.44
  current-firmware: 6.48.6
  upgrade-firmware: 7.6

lab-ROSv7-hAP-AC2
+147561ms
/system routerboard print
+152393ms (Mon Jan 09 2023 16:05:37 GMT+1000 (Vladivostok Standard Time))
       routerboard: yes
        board-name: hAP ac^2
             model: RBD52G-5HacD2HnD
     serial-number: F66B0F2E9521
     firmware-type: ipq4000L
  factory-firmware: 6.46.8
  current-firmware: 6.47.10
  upgrade-firmware: 7.5

lab-ROSv7-hAP-AC3
+147562ms
/system routerboard print
+200420ms (Mon Jan 09 2023 16:06:25 GMT+1000 (Vladivostok Standard Time))
       routerboard: yes
        board-name: hAP ac^3
             model: RBD53iG-5HacD2HnD
     serial-number: E72C0E9F5989
     firmware-type: ipq4000
  factory-firmware: 6.47.9
  current-firmware: 6.47.9
  upgrade-firmware: 7.6

lab-ROSv7-wAP-60G
+147562ms
/system routerboard print
+154818ms (Mon Jan 09 2023 16:05:39 GMT+1000 (Vladivostok Standard Time))
       routerboard: yes
        board-name: wAP 60G
             model: RBwAPG-60ad
     serial-number: 8B94084F8DF5
     firmware-type: ipq4000L
  factory-firmware: 3.40.1
  current-firmware: 7.2.3
  upgrade-firmware: 7.5

lab-ROSv7-wAP-60G-sta
+147563ms
/system routerboard print
+157711ms (Mon Jan 09 2023 16:05:42 GMT+1000 (Vladivostok Standard Time))
       routerboard: yes
        board-name: wAP 60G
             model: RBwAPG-60ad
     serial-number: 8B940864AD79
     firmware-type: ipq4000L
  factory-firmware: 3.40.1
  current-firmware: 3.40.1
  upgrade-firmware: 7.5
andrewhodel commented 1 year ago

board-name works on CHR hosts but it is not shown in the /system routerboard print output.

This is already an existing bug with Mikrotik that I am waiting for them to fix.

andrewhodel commented 1 year ago

The problem is that RouterOS should follow a standard when returning the value of undefined fields.

With model and serial-number the script stops execution. With board-name it returns an empty value.

It should return an empty value with every field or stop script execution with any undefined field.

I'll open another issue with Mikrotik.

andrewhodel commented 1 year ago

SUP-103784