ispc-lab / LiDAR4D

💫 [CVPR 2024] LiDAR4D: Dynamic Neural Fields for Novel Space-time View LiDAR Synthesis
https://dyfcalid.github.io/LiDAR4D
Apache License 2.0
151 stars 14 forks source link

normalize grid_sample coords to [-1 1] value range #2

Closed martinmeinke closed 6 months ago

martinmeinke commented 6 months ago

This seems unintended to me.

grid_sample expects values to be in the [-1 1] range, but it seems that values between 0 and 1 are passed right now, wasting 3/4 of the parameter grid.

dyfcalid commented 6 months ago

Thank you for your PR!