ispras / lingvodoc-react

Apache License 2.0
7 stars 11 forks source link

Implement [x] close button on the top in all dialogs #128

Closed nadezhday closed 4 years ago

nadezhday commented 4 years ago

-Open http://lingvodoc.ispras.ru/dictionary/2639/4263/perspective/2639/4267/view -Open any dialog (e.g. Click Lexical Entries->'Lexical Entries' statistics...) It would be nice to add [x] button on the top of the dialogs so user will not need to scroll down the dialog to press Cancel button. image

-Click Show statictics button image

Problem: Cancel button is not visible in the dialog. So it would be good to have [x] on the top to close this dialog. Right now the user will have to scroll the dialog to find Cancel button. - NOK

al-indigo commented 4 years ago

@myrix if you don't know how to do it, reassign it to Alex or Andrew please

myrix commented 4 years ago

Added close icon to almost all modal dialogs that do not have it already:

  1. Statistics.
  2. Roles.
  3. Create field.
  4. Markup.
  5. Convert EAF.
  6. Player.
  7. Create organization.
  8. Dictionary properties.
  9. Perspective properties.
  10. Cognate analysis.
  11. Phonology.
  12. Save dictionary.
  13. User -> User account activation / deactivation.
  14. User -> Sign in.
  15. User -> Sign up.
  16. User -> Edit profile.
  17. Phonemic analysis.
  18. Search -> Advanced search -> Select languages.
  19. Search -> Advanced search -> Grammar.
  20. Search -> Advanced search -> Select tags.
  21. Search results -> Blobs.
  22. Search results -> Blobs -> View Blob.
  23. Starling import -> Language selection.

Left entity image viewing dialog unchanged, without close icon, because the dialog contains only the image being viewed and close icon would overlap it, preventing user from seeing part of it.

See e.g. http://lingvodoc.ispras.ru/dictionary/671/15154/perspective/748/553/view, filter search "три человека", field "Praat markup", button "View".

Note: both that dialog and all dialogs mentioned above, except for Dictionary properties dialog, can be closed by standard Esc keyboard key press or mouse click on the dimmer outside the dialog. Dictionary properties dialog can still be closed by Esc keyboard key press.

nadezhday commented 4 years ago

Verified.

  1. Statistics. - OK

  2. Roles. - OK

  3. Create field. (Lexical properties->dropdown menu->add new field...) - OK

  4. Markup. - OK

  5. Convert EAF. -OK (Open http://83.149.198.62/dictionary/1232/8789/perspective/1232/8792/view image

  6. Player. (Sound column and click Play button) - OK

  7. Create organization. - OK

  8. Dictionary properties. - NOK (Minor issue. Bug will not be created) [x] is located inside sigment. image

  9. Perspective properties. (My dictionaries-> dropdown menu 'Perspective'->properties) - OK

  10. Cognate analysis. Tools->.. - OK

  11. Phonology. Tools->.. - OK

  12. Save dictionary. -OK image

  13. User -> User account activation / deactivation. - OK

  14. User -> Sign in. - OK

  15. User -> Sign up. - OK

  16. User -> Edit profile. - OK

  17. Phonemic analysis. Tools->.. -OK

  18. Search -> Advanced search -> Select languages. -OK

  19. Search -> Advanced search -> Grammar. - OK

  20. Search -> Advanced search -> Select tags. - OK

  21. Search results -> Blobs. OK

  22. Search results -> Blobs -> View Blob. - OK

  23. Starling import -> Language selection. - OK