search

ispras / lingvodoc-react

Apache License 2.0
8 stars 12 forks source link

Implement result message for Publish Entities operation #228

Closed nadezhday closed 4 years ago

nadezhday commented 4 years ago

Open: http://83.149.198.62/dictionary/2969/4/perspective/2969/5/publish

Click Publish Entities button.

Select user. Click Publish. image

Problem: There is no response for this operation. Was it published? Can we implement any message that indicates that operation was Successful (or publish operation Failed).

If you press Refresh you will see Nothing to publish. But it does not mean that the previous operation was successful.

myrix commented 4 years ago

Added successful update message: image

nadezhday commented 4 years ago

Verified.

nadezhday commented 4 years ago

Covered in selenium test

pavel-ho commented 4 years ago

It looks like Selenium tests found a regression. http://83.149.198.62/dictionary/2969/4/perspective/2969/5/publish click on "Галатия" click Publish entities and there is message appear updated 0 entities. 228

(test_view_lexical_publish.test_lex_publish_entities)

myrix commented 4 years ago

Does not reproduce: image image

Same with 'Meaning' field and 1 or 2 entities.

Probably requires some specific circumstances occurring during testing, need more info.

pavel-ho commented 4 years ago

may be in Telegram it is easier to communicate? @myrix

nadezhday commented 4 years ago

Actually I can also reproduce the problem. Video: 2020-08-17_0results.zip

myrix commented 4 years ago

How to reproduce with certainty.

Start from lingvodoc-2020-04-28.16-51.sql.xz DB state, logged in as administrator, edit Uralic > Udmurt > Dictionary of the Written Monument "Life of St. Theodore: In the Votyak Language of the Elabuga Dialect" (1913) > Lexical Entries (/dictionary/2969/4/perspective/2969/5/edit), search for "Галатия", merge these two entries: image

Go to 'Publish' tab, unpublish 'Phonemic transcription' and 'Meaning' entities, open 'Publish Entities' dialog: image

Select user, click 'Publish All', you'll get message 'Updated 0 entities.': image

myrix commented 4 years ago

Fixed, now works ok: image

nadezhday commented 4 years ago

Backend:2.1.1+1285-d77f3515-2020.10.28-19:17+modified-2020.10.30-04:30 Frontend:35b1abfb-401-staging-server

The problem is reproduced again. login as admin http://83.149.198.62/dictionary/2969/4/perspective/2969/5/publish Unselect Галатия Publish Entities Select Базенова Click Publish

Here is the screenshot (if you press Publish 2, you will get message published 0) - NOK image

myrix commented 4 years ago

Regression caused by faulty recent backend merge, fixed.

nadezhday commented 4 years ago

Verified. Selenium test - PASS