search

ispras / lingvodoc-react

Apache License 2.0
7 stars 11 forks source link

Fully dynamic ToC language status handling #966

Closed myrix closed 1 year ago

myrix commented 1 year ago

Currently if the language has ToC status is determined through 2 criteria, if the language is in the hardcoded list of core languages, and if the language has ToC flag in the metadata. Moreover, the hardcoded list of core languages is duplicated both on the frontend and the backend.

It would be architecturally better if the ToC status would be determined only by the corresponding flag in the metadata, and of course that there would be no frontend/backend duplication and all ToC checks would be performed only on the backend.

Implementing that would among other things require a DB migration adding required metadata flags to all languages present in the hardcoded list.

myrix commented 1 year ago

Implemented.

Edit: naturally requires alembic upgrade head.