search

ispras / qdt

QEMU Development Toolkit
Other
36 stars 8 forks source link

header_paths_shortening oversimplifies paths #87

Open alexian79 opened 1 year ago

alexian79 commented 1 year ago

Hi, thanks for helping me with my previous issue, and would like to report another one. I am trying to generate board that uses cortex-m4 which is defined in "hw/arm/armv7m.h" and function that shortens included headers is actually removing too much of the folders in relative path. If I comment out header_paths_shortening call then I have a correct path generated. image

I have attached sample project that illustrates the issue.

PS. additionally to make it build for version of Qemu I used 7.1.94 I have to replace softmmu_ss to arm_ss like so image

project.zip

laerreal commented 1 year ago

Hi! Improved source set selection for new modules (it fixes 2nd part of the issue).

alexian79 commented 1 year ago

Thank you, yeah it fixed meson build file generation.

PS. just a small issue, I see that there are 3 instances of using isAlive across the project, but rest of it is already using is_alive. isAlive is an issue with newer python3. not sure is it a problem with python2 image