Closed KonstantinGeist closed 5 years ago
Boost:
A shared_connection_block releases its block when it is destroyed or its unblock method is called.
The following simple test case fails:
callbackCalled = false; event(value); CHECK(callbackCalled); { callbackCalled = false; shared_connection_block block(conn); event(value); CHECK(!callbackCalled); } callbackCalled = false; event(value); CHECK(callbackCalled); // <-- fails here because the connection is still blocked
shared_connection_block doesn't have a destructor to unblock its connection, and none of the existing test cases cover this simple scenario.
In this PR I simply add unblock() to the destructor.
Merged, thanks!
Boost:
The following simple test case fails:
shared_connection_block doesn't have a destructor to unblock its connection, and none of the existing test cases cover this simple scenario.
In this PR I simply add unblock() to the destructor.