search

ispyb / ispyb-database-modeling

4 stars 3 forks source link

sessionId and blSampleId columns on dataCollection table #22

Open ispyb opened 6 years ago

ispyb commented 6 years ago

Hi,

sessionId exists within dataCollectionGroup and it associates a data collection group to the experimental session or visit. It is not NULL so it is filled in for each data collection group.

By other hand, a data collection is always linked to a data collection group. I wonder if someone knows why sessionId is also existing in the dataCollection Table.

Likewise for blSampleId.

I think it is redundant and unnormalizes the data model. So, we propose to remove them.

datacollection

KarlLevik commented 6 years ago

These columns were left over from the time before we had the DataCollectionGroup table. At Diamond we decided to not drop these columns until all applications were switched over to using DCG as the source of these columns.

I will need to check if we're ready to drop these now. It would be fine if other collaborators dropped them in their databases in the meantime.

delageniere commented 6 years ago

Ok, so then I will prepare the scripts and drop them at ESRF.

stufisher commented 6 years ago

You are making some very large assumptions removing blsample from datacollection. You are assuming that your group is only on one sample. Long term this is very restrictive. You have deprecated a number of columns from datacollection -> datacollectiongroup and these create serious restrictions

delageniere commented 5 years ago

At Soleil September 12th 2019 meeting: decided to let it like it is for now, and see later if really too restrictive as no use case really found. The synchweb code may need to be updated to use the blsampleId in dataCollectionGroup.