ispyb / ispyb-database-modeling

4 stars 3 forks source link

Add AxisStart to EnergyScan / XFESpectrum #30

Closed stufisher closed 5 years ago

stufisher commented 6 years ago

We would like to record axis start position along with EnergyScans / MCAs.

Thus would like to add AxisStart float to EnergyScan & XFEFluorescenceSpectrum

KarlLevik commented 6 years ago

What about axisEnd, axisRange?

antolinos commented 6 years ago

It is fine with us

stufisher commented 6 years ago

You dont generally do rotation with an xfe scan?

KarlLevik commented 5 years ago

@stufisher In that case, isn't 'axisStart' a misleading name? If you have a start, that implies an end, and a range between them ...

stufisher commented 5 years ago

its just consistent with other tables. but if you wanna call it axisposition or something then as you like...

KarlLevik commented 5 years ago

These changes are now 'live' at Diamond as well, so this issue can be closed.