search

ispyb / ispyb-database-modeling

4 stars 3 forks source link

Schema fixing: modify DataCollection.runStatus to become an enum #34

Open KarlLevik opened 5 years ago

KarlLevik commented 5 years ago

Currently, DataCollection.runStatus is a varchar(45). I think it would make sense if this was modified to become an enum. Currently, we (DLS) populate the column with the below values:

We're also discussing a fourth option:

NULL means that the data collection is still running. 'DataCollection Successful' means that the data collection has completed successfully. 'DataCollection Stopped' means that the data collection was interrupted by the user. 'DataCollection Unsuccessful' means that the data collection has completed unsuccessfully, i.e. failed in some way, e.g. due to missing images.

KarlLevik commented 5 years ago

At the VC today Olof suggested there should be a default 'DataCollection Started' value, so that should also be an enum option.

delageniere commented 5 years ago

Changes are ok for us, agreed at VC of January 14th.