ispyb / ispyb-database-modeling

4 stars 3 forks source link

Extend fileType enum in table DataCollectionFileAttachment #7

Closed KarlLevik closed 6 years ago

KarlLevik commented 7 years ago

In DataCollectionFileAttachment table we would like to extend the fileType enum, and I've also included a comment to better document what the different options are for:

ALTER TABLE DataCollectionFileAttachment MODIFY fileType enum('snapshot', 'log', 'xy', 'recip') 
COMMENT 'snapshot: image file, usually of the sample. 
log: a text file with logging info. 
xy: x and y data in text format. 
recip: a compressed csv file with reciprocal space coordinates.';

Can this be merged into the official schema?

antolinos commented 7 years ago

It has sense to us. If nobody is against and you want to consolidate such change into the ISPyB database I will ask @delageniere to add some documentation in the ISPyB webpage (readme.md) about how to integrate changes in the data model on ISPyB.