search

ispyb / py-ispyb

ISPyB backend server based on FastAPI
GNU Lesser General Public License v3.0
12 stars 14 forks source link

mysql-connector-python==8.0.29 in requirements.txt, but not in setup.cfg #218

Closed KarlLevik closed 2 years ago

KarlLevik commented 2 years ago

Should this line specify version 8.0.29, just like in requirements.txt? https://github.com/ispyb/py-ispyb/blob/4d48f7f393c7949ea49956b254783f2e46cca5dc/setup.cfg#L47

stufisher commented 2 years ago

Yes, feel free to make a pr, thanks!

KarlLevik commented 2 years ago

I also see that the project depends on mysql-connector in addition to mysql-connector-python.

Apparently, mysql-connector is just an older version of what is now mysql-connector-python: https://github.com/pypi/warehouse/issues/5537

So we should probably remove mysql-connector from the requirements.txt and setup.cfg files.