search

ispyb / py-ispyb

ISPyB backend server based on FastAPI
GNU Lesser General Public License v3.0
12 stars 14 forks source link

Add container/sample queue routes #256

Open stufisher opened 1 year ago

stufisher commented 1 year ago

Related sql changes: https://github.com/DiamondLightSource/ispyb-database/pull/63/files

Could be made more optional by checking if tables exist

codecov[bot] commented 1 year ago

Codecov Report

Merging #256 (36e4576) into master (c45a43a) will decrease coverage by 0.44%. The diff coverage is 49.65%.

@@            Coverage Diff             @@
##           master     #256      +/-   ##
==========================================
- Coverage   65.89%   65.45%   -0.44%     
==========================================
  Files         112      112              
  Lines        5313     5454     +141     
==========================================
+ Hits         3501     3570      +69     
- Misses       1812     1884      +72
Impacted Files Coverage Δ
pyispyb/core/modules/containers.py 18.26% <14.70%> (-9.24%) :arrow_down:
pyispyb/core/routes/containers.py 50.81% <40.74%> (-9.19%) :arrow_down:
pyispyb/core/schemas/containers.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c45a43a...36e4576. Read the comment docs.

mgaonach commented 1 year ago

How are the queues created? Do we not need a POST route for that?

stufisher commented 1 year ago

daiquiri populates this directly, but yes, for mxcube you'd need a resource (and also mxcube would need to link back the datacollection to the related diffractionplan)