Open dburckh opened 3 years ago
https://github.com/israel-fl/bitmap2video/blob/f51c404aed29e5f7043144a2ddc738f51b589d21/app/src/main/java/com/homesoft/bitmap2video/MainActivity.kt#L134
This is probably OK, but it seems a little scary. If this Thread hangs it will sit out there indefinitely. Usually an Executor or ThreadPool. At the minimum, I would name the Thread so you know what is supposed to be doing.
https://github.com/israel-fl/bitmap2video/blob/f51c404aed29e5f7043144a2ddc738f51b589d21/app/src/main/java/com/homesoft/bitmap2video/MainActivity.kt#L134
This is probably OK, but it seems a little scary. If this Thread hangs it will sit out there indefinitely. Usually an Executor or ThreadPool. At the minimum, I would name the Thread so you know what is supposed to be doing.