search

israpps / HDL-Batch-installer

A GUI for HDL Dump. Featuring batch installation of PS2 games to PS2 internal hdd and some game management utilities
https://israpps.github.io/HDL-Batch-installer/
GNU General Public License v3.0
223 stars 11 forks source link

[bug]: Doesn't detect PS2 HDD if there are a lot of drives in the system #28

Closed Flygsand closed 2 years ago

Flygsand commented 2 years ago

Issue

I have about 20 drives (physical and virtual) in my system and HDL Batch Installer won't recognize my PS2 drive (currently drive number 20). I've encountered the same issue with HDL Dumb (which has a hardcoded limit of 16 drives), HDLBATCH and OPL Manager.

expected behaviour

Expected behavior: my PS2 HDD is found.

Program version

3.3.0 revision 1

other checks

israpps commented 2 years ago

Hi!

This is an HDLDump issue, not directly related to my GUI.

I'll take a look at this in a few days...

However, if you want to speed up things a bit, please open a issue on HDLDump

israpps commented 2 years ago

After a quick inspection it seems that HDLDump only iterates on the first 16 drives...

I already asked the project maintainer if such limit can be increased

israpps commented 2 years ago

Already Opened a Pull Request on hdl-dump...

The maintainer said he isn´t aware of any issue....

Actually, hdl-dump of ancient times was limited to only 4 drives AFAIK

israpps commented 2 years ago

Fixed on HdlDump mainstream

Merged to my own repo...

Update on your HDL Batch installer package with the HdlDump update feature

Or re-download package

Flygsand commented 2 years ago

Thanks for this @israpps. I can confirm that the drive (currently numbered 18) is now detected and I'm instead seeing the error associated with #29.

israpps commented 2 years ago

Thanks for this @israpps. I can confirm that the drive (currently numbered 18) is now detected and I'm instead seeing the error associated with #29.

yeah, yesterday while i was drunk i fixed the issue...

I might release a fix today