israpps / HDL-Batch-installer

A GUI for HDL Dump. Featuring batch installation of PS2 games to PS2 internal hdd and some game management utilities
https://israpps.github.io/HDL-Batch-installer/
GNU General Public License v3.0
215 stars 11 forks source link

[FR]: Better way to add new icons #40

Open luissilva1044894 opened 1 year ago

luissilva1044894 commented 1 year ago

Explanation

Make a new repo and add me as Contributor? Or I should make a public repo which you'll "fork" later?

I'm planning to add as many icons as possible. If you've any idea, tell me.

fature related

other checks

israpps commented 1 year ago

Not really, I'm not sure if it's safe to hold the bare icons on the repo

You can make a repo to organize yourself

And when you want to make the PR just pack the files and do the PR

luissilva1044894 commented 1 year ago

Why? Copyright or something like?

Well, isn't that hard to unzip your file... Password is hardcoded in the repo (That's why I got it without asking for). I don't see why it should be less safe.

Whatever, I was thinking something like your FMCB repo automatically uploading files. But I think should be better to use .json or folder based system. It's turning hard to follow that .ini (2469 lines currently, gamename.DB has +15000 lines. Turned it alphabetically, but still...) and 7z file will be ever more big.

israpps commented 1 year ago

Maybe

But keeping the list as an INI is easier and simpler from code side

Maybe make a system that builds the package from the style you want into the style used by the program

luissilva1044894 commented 1 year ago

Check my repo now.

It's already generating .7z (With your pass!). Better to review, less prone to errors.

Only changes I really made was: Removed unecessary # and reordered Icons.ini to match gamename DB.

israpps commented 1 year ago

@luissilva1044894 users are reporting duplicated entries on the ini

Maybe you can check it.

I'm too busy ATM

luissilva1044894 commented 1 year ago

Well, I'm working on a CDN like for PS2 icons. There are only 940 icons there rn. Unlike your .zip, some icons are duplicated.

https://playstation2-icons.onrender.com/{game_id}/icon.sys (HDD format. All values extracted from save) https://playstation2-icons.onrender.com/{game_id}/list.ico https://playstation2-icons.onrender.com/{game_id}/del.ico (md5 != list.ico or 404 error) https://playstation2-icons.onrender.com/{game_id}/copy.ico (md5 != list.ico or 404 error, not needed for HDDOSD)

Or https://playstation2-icons.onrender.com/{game_id} which returns a zip containing all files.

I'm still working on title0 & title1. Looking for a better DB for parsing the names, I'll use SerialStation, I guess.

I'll asking later on #savedata-sharing/GDX, but what u think? Can you send me the saves u have?