search

israpps / HDL-Batch-installer

A GUI for HDL Dump. Featuring batch installation of PS2 games to PS2 internal hdd and some game management utilities
https://israpps.github.io/HDL-Batch-installer/
GNU General Public License v3.0
215 stars 11 forks source link

Change lang folder from"ko-KR" to "ko" #49

Closed DDinghoya closed 11 months ago

israpps commented 1 year ago

hi!

May I ask what is the purpose of this PR?

DDinghoya commented 1 year ago

hi!

May I ask what is the purpose of this PR?

In the first folder name "ko-KR", Korean was not output. So, I requested a PR thinking that there would be no problem if I changed the folder name to "ko".

israpps commented 1 year ago

sorry for taking so long...

I added the Korean Localization to the program internals...

Just tested and it seems that the program expects the catalog to be located at

Lang\ko_KR\HDLBinst.mo
israpps commented 1 year ago

your issue has been fixed on commit https://github.com/israpps/HDL-Batch-installer/commit/b367cca239f7d1fbf6e930f6703e8352974fcacd

The problem was that the new korean locale was not transferred to the release packages because the ko_KR folder was missing...

Now it should work as i added the wxwidgets Korean locale for standard error messages. So the folder will always exist from now on

DDinghoya commented 1 year ago

your issue has been fixed on commit b367cca

The problem was that the new korean locale was not transferred to the release packages because the ko_KR folder was missing...

Now it should work as i added the wxwidgets Korean locale for standard error messages. So the folder will always exist from now on

Thank you for your strong support! :)

It is perfect if only the untranslated square box of the language item is resolved.

HDL-Batch-installer

israpps commented 1 year ago

You mean localizing the language names?

DDinghoya commented 1 year ago

You mean localizing the language names?

Yup! There are translated it on po file. However, Not apply them on box