[bug]: Download assets not working

[LeCrabeInfo]

Issue

The assets are downloaded, but their size is 0 byte. Then the cleanup script is executed and deletes them because files are empty.

expected behaviour

Assets downloaded.

Program version

3.5.0 Revision 1

Relevant log output

Downloading...
[SCES_504.91]
SCES_504.91_COV.jpg - 0
SCES_504.91_COV.jpg is empty
SCES_504.91_ICO.png - 0
SCES_504.91_ICO.png is empty
Download finished!

In which package have you experienced this issue?

64 bits

other checks

• [X] I tested the Latest version

[LeCrabeInfo]

The weird thing is that it works via PowerShell:

.\common\wget.exe --no-check-certificate --show-progress "https://ia801805.us.archive.org/view_archive.php?archive=/26/items/OPLM_ART_2021_01/OPLM_ART_2021_01.zip&file=PS2%2FSCES_504.91%2FSCES_504.91_COV.jpg" -O .\Downloads\ART\SCES_504.91_COV.jpg

--2023-03-06 12:25:08--  https://ia801805.us.archive.org/view_archive.php?archive=/26/items/OPLM_ART_2021_01/OPLM_ART_2021_01.zip&file=PS2%2FSCES_504.91%2FSCES_504.91_COV.jpg
Resolving ia801805.us.archive.org (ia801805.us.archive.org)... 207.241.230.175
Connecting to ia801805.us.archive.org (ia801805.us.archive.org)|207.241.230.175|:443... connected.
WARNING: cannot verify ia801805.us.archive.org's certificate, issued by 'CN=Go Daddy Secure Certificate Authority - G2,OU=http://certs.godaddy.com/repository/,O=GoDaddy.com\\, Inc.,L=Scottsdale,ST=Arizona,C=US':
  Self-signed certificate encountered.
HTTP request sent, awaiting response... 200 OK
Length: unspecified [image/jpeg]
Saving to: './Downloads/ART/SCES_504.91_COV.jpg'

./Downloads/ART/SCES_504.91_C     [ <=>                                              ]   8,00K  --.-KB/s    in 0,001s

2023-03-06 12:25:10 (8,96 MB/s) - './Downloads/ART/SCES_504.91_COV.jpg' saved [8194]

[LeCrabeInfo]

I have disabled Windows Firewall and Windows Defender. I have deleted HDLBI AppData files, downloaded new archive. But same problem.

[israpps]

Maybe the --no-check-certificate is the clue

[LeCrabeInfo]

I actually need to add --no-check-certificate option because when I don't:

.\common\wget.exe --show-progress "https://ia801805.us.archive.org/view_archive.php?archive=/26/items/OPLM_ART_2021_01/OPLM_ART_2021_01.zip&file=PS2%2FSCES_504.91%2FSCES_504.91_COV.jpg" -O .\Downloads\ART\SCES_504.91_COV.jpg

--2023-03-08 10:35:24--  https://ia801805.us.archive.org/view_archive.php?archive=/26/items/OPLM_ART_2021_01/OPLM_ART_2021_01.zip&file=PS2%2FSCES_504.91%2FSCES_504.91_COV.jpg
Resolving ia801805.us.archive.org (ia801805.us.archive.org)... 207.241.230.175
Connecting to ia801805.us.archive.org (ia801805.us.archive.org)|207.241.230.175|:443... connected.
ERROR: cannot verify ia801805.us.archive.org's certificate, issued by 'CN=Go Daddy Secure Certificate Authority - G2,OU=http://certs.godaddy.com/repository/,O=GoDaddy.com\\, Inc.,L=Scottsdale,ST=Arizona,C=US':
  Self-signed certificate encountered.
To connect to ia801805.us.archive.org insecurely, use `--no-check-certificate'.

What is weird is that I tested on another machine and it works.

[israpps]

must be an issue with your certs

[ironsniper1]

i am having the exact same issue, went back to version 3.0.3 and it would download assets but they would be 0 bytes in size and not able to be opened, as well if i tried to download assets for more than one game at a time hdl batch crashes

[israpps]

let me guess. windows 7?

[ironsniper1]

let me guess. windows 7?

windows 10 latest version, this is also a very fresh install and the laptop is only used for checking hard drives

[israpps]

let me guess. windows 7?

windows 10 latest version, this is also a very fresh install and the laptop is only used for checking hard drives

odd indeed. I tested the download feature while coding the current latest update and it worked like a charm...

[ironsniper1]

let me guess. windows 7?

windows 10 latest version, this is also a very fresh install and the laptop is only used for checking hard drives

odd indeed. I tested the download feature while coding the current latest update and it worked like a charm...

if there is anything you would like me to try let me know

[ironsniper1]

[israpps]

you should be getting at least an error there....

[ironsniper1]

im not getting any errors

[israpps]

open a windows terminal on the HDL Batch installer folder then paste this into the terminal

common\wget.exe https://ia801805.us.archive.org/view_archive.php?archive=/26/items/OPLM_ART_2021_01/OPLM_ART_2021_01.zip&file=PS2%2FSLPM_666.75%2FSLPM_666.75_COV.jpg -O SLPM_666.75_COV.jpg
echo %errorlevel%
PAUSE

If it really fails, an error will arise. else it will download kingdom hearts 2 final mix cover art

[ironsniper1]

[israpps]

sorry please prepend an ^ to the ampersand simbol (,ust look like this^&)

common\wget.exe https://ia801805.us.archive.org/view_archive.php?archive=/26/items/OPLM_ART_2021_01/OPLM_ART_2021_01.zip^&file=PS2%2FSLPM_666.75%2FSLPM_666.75_COV.jpg -O SLPM_666.75_COV.jpg
echo %errorlevel%
PAUSE

[ironsniper1]

[israpps]

ok...

lets try this now:

common\wget.exe https://ia802706.us.archive.org/view_archive.php?archive=/4/items/OPLM_ART_2023_07/OPLM_ART_2023_07.zip^&file=PS2%2FSLPM_666.75%2FSLPM_666.75_COV.jpg -O SLPM_666.75_COV.jpg
echo %errorlevel%
PAUSE

[ironsniper1]

same error, it cannot verify, i did find thishttps://serverfault.com/questions/314635/why-wget-doesnt-verify-ssl-certificates all though its linux it says wget is having an issue with openssl

[israpps]

im not an expert on network stuff.... but that error seems like a complain about the website certs...

try this please:

common\wget.exe --no-check-certificate https://ia802706.us.archive.org/view_archive.php?archive=/4/items/OPLM_ART_2023_07/OPLM_ART_2023_07.zip^&file=PS2%2FSLPM_666.75%2FSLPM_666.75_COV.jpg -O SLPM_666.75_COV.jpg
echo %errorlevel%
PAUSE

[ironsniper1]

just tried that before seeing your reply and it works

[israpps]

ok... coding a release with the option for this

[ironsniper1]

just got a new error, when i tried to open the zip file it couldnt be opened by windows or 7zip

[ironsniper1]

[israpps]

you forgot to add ^ before ampersand. without it, windows thinks the text after & is a command to be ran if the text before it runs successfully as a command

[israpps]

HDL-Batch-installer.zip try this pls

[ironsniper1]

works perfectly!