search

issalig / toshiba_air_cond

AB protocol decoder for toshiba air conditioners
37 stars 9 forks source link

PlatformIO and some refactors #12

Open jvegaf opened 2 years ago

jvegaf commented 2 years ago

Hi,

I've migrated the Arduino project to PlatformIO because its more feats like:

image

test with my nodemcu board is working perfect 😄 image

Coming soon will like send a some PR with more little refactors

Regards

jvegaf commented 2 years ago

Sorry, I forget extract in other branch the code refactors, even so I did testing and commit each little change for avoid broke nothing.

The main reason of this refactors is separate responsibilities in different modules, making this great project more testable and robust, so that will be more easy add new features.

issalig commented 2 years ago

Hi, thanks for your work. It is nice to see other people collaborating. I'm busy these days but I will take a look as soon as possible. Is it possible to have the code for Arduino IDE and PlatformIO? Last time I tried PlatformIO I had to change .ino extensions and some other things but I would like to have it working for both frameworks.

jvegaf commented 2 years ago

I'll look at a way to make it compatible with both environments.

in my case when l tried platformIO didn't feel like back to arduino.

jvegaf commented 2 years ago

I found the solution 🚀🚀🚀

now works with both environments.

compiled with Arduino 👇🏻

image

issalig commented 2 years ago

Great. I will take a look asap

issalig commented 2 years ago

Sorry, still no time.

jvegaf commented 2 years ago

Sorry, still no time.

Don't worry friend, that's things happen to everybody. Trust me, I prefer that you take it with calm because you better understand the changes that I propose you.

Now I am doing a few changes to the PCB for achieve works with a NodeMCU board (I have many of this boards forgotten in a drawer 😄 ).

I will make a pcb piece when I end the changes to continue playing with the project.

snetekombinerke commented 2 years ago

Hi, Is is possible to get finished pcb?

issalig commented 2 years ago

Hi @snetekombinerke , if you are interested in my version for wemos d1 mini write me at mejijof@getnada.com for more details about getting the pcb. If it is the nodeMCU, just contact jvegaf.

jvegaf commented 2 years ago

Hi @snetekombinerke , if you are interested in my version for wemos d1 mini write me at mejijof@getnada.com for more details about getting the pcb. If it is the nodeMCU, just contact jvegaf.

@issalig @snetekombinerke just I released the esp32 pcb version 😁

https://github.com/jvegaf/toshiba_air_cond/releases/tag/esp32_v1

airpcb_smd_board

airpcb_smd_top

airpcb_smd_bottom

issalig commented 2 years ago

Nice!

@jvegaf, BTW I wrote you an email to your gmail some weeks ago, not sure if you got it.

jvegaf commented 2 years ago

Nice!

@jvegaf, BTW I wrote you an email to your gmail some weeks ago, not sure if you got it.

I've searched in my gmail but I doesn't found it.

@issalig can you resend me it again ?

Thanks

issalig commented 2 years ago

Is josevega234 correct? it is where I sent it.

jvegaf commented 2 years ago

I sended you a email to your mejijof at getnada dot com account

issalig commented 2 years ago

Ok. Got it.

jvegaf commented 2 years ago

I replied your mail 😊

snetekombinerke commented 2 years ago

Hi, I've sent you an email 30. avg., 21:39. Please check.

jvegaf commented 1 year ago

Yes gmail dot com

El sáb, 27 ago 2022, 12:51, issalig @.***> escribió:

Is josevega234 correct? it is where I sent it.

— Reply to this email directly, view it on GitHub https://github.com/issalig/toshiba_air_cond/pull/12#issuecomment-1229170040, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIGROWBWW636QAC4LBCA33V3HXKBANCNFSM5SKBCWYA . You are receiving this because you were mentioned.Message ID: @.***>

obvious-creations commented 1 year ago

Hi @jvegaf, was just wondering how far did you get this? I was looking out for solutions for our Toshiba air conditioner units and stumbled across this project