Add ServiceAsync - Githubissues

issamansur / vkpymusic

The library allows developers to easily perform operations related to music and other functionalities available through the VK API.

https://issamansur.github.io/vkpymusic/

MIT License

21 stars 3 forks source link

Add ServiceAsync #2

Closed MrDragar closed 12 months ago

issamansur commented 12 months ago

@MrDragar Hi, thank u for your PR. I will look at the changes and make a decision. I really don't know if this asynchrony is necessary for the Service, but in any case, thank you very much!

MrDragar commented 12 months ago

I just forked you're library for my Telegram bot. Thanks for vkpymusic

issamansur commented 12 months ago

glad to help) Question: Did you need an asynchronous version of the Service for the bot to work?

MrDragar commented 12 months ago

I could use a synchronous version, but I don't want to deal with multithreading problems (I use Aiogram and Tortoise ORM)

MrDragar commented 12 months ago

Last 2 commits were made for myself. Don't apply them please

issamansur commented 12 months ago

Thank u again, but next time please:

create new branch in forked repository with name associated with issue. For example, add-service-async)
if u do some mistake in commit, use amend for apply this changes in last commit, don't in new)
if u want add some changes for yourself u can create another branch)

P. S. this is just advices)