search

isshoni-soft / winry

Isshoni Bootstrapper, uses introspection & code generation to streamline bootstrapping & general development
0 stars 0 forks source link

Investigate issues that could arise from the Winry class's statics #23

Closed Dragovorn closed 2 years ago

Dragovorn commented 2 years ago

Copy & paste from todo comment block I wrote about this in Winry.class:

Look into what would happen if two different instances of Winry were used.
Think of in the context of a bukkit plugin, multiple plugins using Winry
Will probably break if they use `Winry.getBootstrapper()` and expect their
bootstrapper to be present instead of the most recently 'used' one.
Dragovorn commented 2 years ago

This resulted in me removing all static components from winry, instead their functionality was replaced by IWinryContext & strategic constructor dependencies.