search

isso-comments / isso

a Disqus alternative
https://isso-comments.de
MIT License
5.05k stars 437 forks source link

Cant show Isso in Swedish #197

Closed gntech closed 8 years ago

gntech commented 9 years ago

Hi, I am running isso 0.9.10 on my site and even though a swedish translation exists i cant make it visible. It defaults back to english when i set data-isso-lang="sv"

<script
  data-isso="/comments"
  data-isso-vote="false"
  data-isso-lang="sv"
  src="/comments/js/embed.min.js">
</script>
<section id="isso-thread"></section>

Ref: https://github.com/posativ/isso/commit/7f5ff457c1c1ba0d86031615314153c70d2f138c

posativ commented 9 years ago

Do you have a link to your embed.min.js file?

gntech commented 9 years ago

http://gntech.se/comments/js/embed.min.js

posativ commented 9 years ago

I doubt you run 0.9.10, you only have de, en, fr, it, eo and ru.

gntech commented 9 years ago

That is strange. I have installed isso in a virtualenv using pip. Is there some way to verify which version is acutally installed?

gntech commented 9 years ago

Turns out the Swedish translation isnt available in the 0.9.10 release after all. I just assumed since the pull request was accepted Before the release. https://github.com/posativ/isso/blob/0.9.10/isso/js/app/i18n.js Is it possible to do a new release with updated translations?

posativ commented 9 years ago

Yes, exactly. I'll try to publish a new release today.

gntech commented 9 years ago

Thats great, thanks! :+1:

gntech commented 9 years ago

@posativ is there some way I can help out with the new release?

posativ commented 9 years ago

Next week might be possible, I need to fix a few things for the master (most translations are submitted to the master branch), especially #191 (if you have an idea on how to simply extend the dom without wrapping all methods, let me know).