search

isso-comments / isso

a Disqus alternative
https://isso-comments.de
MIT License
5k stars 442 forks source link

Disqus import not keeping the thread IDs #563

Open fluffy-critter opened 4 years ago

fluffy-critter commented 4 years ago

Hi, I'm trying to migrate my site from Disqus to isso, and while I was able to import my comments and the importer showed the specified thread IDs during the import, the actual database is still using the page URI as the thread identifier. For example:

sqlite> select uri,title from threads limit 5;
/comics/journal/400-Shoes|Journal: Shoes
/comics/journal/278-Things-that-go-splat-in-the-night|Journal: Things that go splat in the night
/comics/journal/322-Explosion|Journal: Explosion
/comics/journal/353-Rejection|Journal: Rejection
/comics/journal/469-Scary-pizza|Journal: Scary pizza

IN the above example, the thread with a thread ID of /comics/journal/400-Shoes should actually have a thread ID of mt_1949. When my site is configured to pull the comments with e.g.

<div id="isso-thread" data-thread-id="mt_1949">

the script correctly tries to retrieve the data with OPTIONS /?uri=mt_1949 but that doesn't return any results, as expected.

So, is there any way to tell the Disqus importer to use the specified thread ID rather than the URI?

fluffy-critter commented 4 years ago

As a workaround I made a local modification to the import script over in this branch. When I can get the unit tests working (and possibly figure out how to make this an option) I'll open a PR.

fluffy-critter commented 4 years ago

Ah, and now I see that the thread IDs are also used as the page link when a reply is sent. So this is much more complicated to implement than I thought.

I’ll work on this over the next few days though, as this is an important feature to me.

fluffy-critter commented 4 years ago

I ended up using an alternate approach and just migrated my thread IDs. Feel free to backburner/close this feature request as appropriate.

ix5 commented 2 years ago

https://github.com/fluffy-critter/isso/commits/disqus-thread-id looks pretty much ready for prime-time to me.

Do you think you could find the time to make any changes you felt were still necessary and then have one of the other maintainers take a look at it? I'd be happy to review.