search

isso-comments / isso

a Disqus alternative
https://isso-comments.de
MIT License
5k stars 442 forks source link

Admin interface uses public-endpoint instead of host when linking to posts #647

Open Konzertheld opened 4 years ago

Konzertheld commented 4 years ago

What the title says. I can't use the links to my posts in the comments lists because they use the wrong base URL. I use public-endpoint as per this workaround: https://github.com/posativ/isso/issues/558#issuecomment-511029858

So the links are test.site.de/post-slug but should instead be site.de/post-slug as the front site does not run on a subdomain.

Now I am unsure if this is expected behaviour and a consequence of the other bug or a separate bug...

EchedelleLR commented 3 years ago

I am on the same issue.

ix5 commented 3 years ago

The main issue is that isso isn't aware of any "host" parameter, it only records a relative uri path component. As such, only the uri component is rendered in the admin interface: admin.html.

I've decided for myself to use full URLs instead of paths, see uri-location-full, but that's not feasible for upstream isso.

You might use the local() interface to access e.g. origin which resolves to the first(?) host you defined in your config - and pass that host to the template via the admin endpoint.

ix5 commented 2 years ago

Related: https://github.com/posativ/isso/issues/566