search

isso-comments / isso

a Disqus alternative
https://isso-comments.de
MIT License
5k stars 442 forks source link

Isso doesn't show or display errors #673

Open NCommander opened 3 years ago

NCommander commented 3 years ago

When either loading comments or posting, if an error occurs such as failing to read an endpoint, or if a comment is too short, etc. it just fails silently, I would be most welcome to fix this. I had quite a long and painful effort to get isso working on my website.

jelmer commented 3 years ago

On Sun, Oct 18, 2020 at 11:06:47PM -0700, Michael Casadevall wrote:

When either loading comments or posting, if an error occurs such as failing to read an endpoint, or if a comment is too short, etc. it just fails silently, I would be most welcome to fix this. I had quite a long and painful effort to get isso working on my website. Contributions to improve the client side code here would be great.

-- Jelmer Vernooij jelmer@jelmer.uk PGP Key: https://www.jelmer.uk/D729A457.asc

ix5 commented 2 years ago

Related as reported by @m-cat in https://github.com/posativ/isso/issues/441

Was playing with the cute little demo on the Isso page when I went and I put asdf as the email. Clicking "submit" did nothing, but there was no indication that the email input was invalid (I tested on Firefox, it does not accept asdf for an input of type='email'). I believe you must have overriden the box-shadow css attribute which is used by default (at least in Firefox) to highlight invalid fields.

I guess the intention might be to let the client display an error message in this case using JS or something? It should still be up to the user whether they want to override the :invalid style.

Edit: actually, it appears that the website field is the culprit. Seems backwards haha, I would verify the email but not the website, which can just be "google" or something.