Closed jynus closed 1 year ago
Hey, sorry for the late response - the change looks good to me, feel free to create a PR ^^
Will do.
There you have it- I chose to short circuit the 3 main blocks, as I thought it was clearer in this case than the "single return at the end". I tested it by connecting and reconnecting to several channels and deleting the cache files several times, but further testing will be welcome, too! :-D
Thank you a lot!
I did the following:
I got the following error:
Invalid get index 'badge_sets' (on base 'Dictionary').
(gift_node.gd:525)I guessed that it assumes that if the cache exists, it contains this key. I fixed the issue by changing the logic to this:
Let me know what you think and I can send you a PR, if it seems like a reasonable change.