search

issoseva / issoseva-old

Issoseva.org website
1 stars 0 forks source link

when there are more than 3 events/testimonials (columns), the next row should be left aligned instead of right. #31

Closed vidhikesaria closed 7 years ago

vidhikesaria commented 7 years ago

image

yogeshkhatri1989 commented 7 years ago

i think you want it to be left aligned instead of right as in the screenshot/site its already right aligned. So should i make it left aligned?

nojvek commented 7 years ago

Just fixed title. Left aligned should be the correct expected behaviour. Thanks @yogeshkhatri1989

yogeshkhatri1989 commented 7 years ago

main.scss and main.css are not synced, are we doing changes directly in main.css file and should i also do changes in main.css?

nojvek commented 7 years ago

I would really love it if we operated everything off main.scss and added the transpilation to css as part of fab deploy which would run yarn build step when travis-ci runs.

Any chance you can investigate what differences there are and make main.scss the source of truth. We can remove the main.css completely from the repo.

Thanks for bringing this up @yogeshkhatri1989

yogeshkhatri1989 commented 7 years ago

sure, will fix this.

yogeshkhatri1989 commented 7 years ago

have changed main.scss to incorporate changes from main.css. removed main.css and added compilation of css file on deploy in fabfile please ensure sass is installed on server before merging/deploying

nojvek commented 7 years ago

Thanks. Will look at the PR

On Sun, Oct 1, 2017 at 9:55 AM Yogesh Khatri notifications@github.com wrote:

have changed main.scss to incorporate changes from main.css. removed main.css and added compilation of css file on deploy in fabfile please ensure sass is installed on server before merging/deploying

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/issoseva/issoseva.org/issues/31#issuecomment-333390387, or mute the thread https://github.com/notifications/unsubscribe-auth/AA-JVBg16a4fCggzahSH_jdbLHJjnCXmks5sn8P8gaJpZM4Pmle6 .

nojvek commented 7 years ago

Fixed by #32