issp-center-dev / mVMC

A numerical solver package for a wide range of quantum lattice models based on many-variable Variational Monte Carlo method
http://www.pasums.issp.u-tokyo.ac.jp/mvmc/en/
GNU General Public License v3.0
59 stars 19 forks source link

We Should Fix Traditional Makefile Compilation #15

Open xrq-phys opened 4 years ago

xrq-phys commented 4 years ago

An easy workaround would be:

In src/StdFace/makefile_StdFace:

StdFace_OBJS = StdFace_main.o StdFace_ModelUtil.o
Lattice_OBJS = SquareLattice.o ChainLattice.o TriangularLattice.o \
        HoneycombLattice.o Ladder.o Kagome.o Orthorhombic.o FCOrtho.o \
        Pyrochlore.o Wannier90.o setmemory.o # <<< Add this

In src/ComplexUHF/makefile_uhf:

include ../make.sys

SFMT = ../sfmt/SFMT.o

OBJS = \
../common/setmemory.c \ # <<< Add this
cal_energy.o \
diag.o \
green.o \
initial.o \
makeham.o \
matrixlapack.o \
output.o \
readdef.o \
UHFmain.o

and delete all lines related to mfmemory.c.

To be honest, after experiencing many CMake-related problems, I'm beginning to doubt that CMake might not be a good toolset for us:

As a result, I guess we should at least continue to support old makefile and remove that makefile is deprecated warning. BTW adding -x permission to mVMCconfig.sh might also be a good idea :)

Best, RuQing