search

issp-center-dev / mVMC

A numerical solver package for a wide range of quantum lattice models based on many-variable Variational Monte Carlo method
http://www.pasums.issp.u-tokyo.ac.jp/mvmc/en/
GNU General Public License v3.0
59 stars 19 forks source link

Private dev #25

Closed tmisawa closed 3 years ago

xrq-phys commented 3 years ago

I would suggest moving StdFace submodule from /src/StdFace/submodule to /src/StdFace.

@tmisawa how do you think? Btw it seems that the traditional makefile also needs fixing (which is easy).

yomichi commented 3 years ago

@xrq-phys I agree with your suggestion.

The submodule is a nice mechanism to include other projects, but this works only when git cloned although we sometimes want to use archive file to obtain sources. This is why other ISSP's projects have such as StdFace/submodule and other directories to by-pass the submodule mechanism (eg. download or manual clone).

Today, I found a smart tool, git-archive-all. This can make an archive file that includes a copy of the submoduled repositories. I think that it is better to attach this archive file to the release page.

xrq-phys commented 3 years ago

@yomichi Sorry I didn't see the /src/StdFace/CMakeList.txt which clones StdFace to /src/StdFace/clone.

Yes! git archive does not support recursive behavior, which is quite annoying.

I'll wait until you finished deploying git-archive-all to, maybe, dist.sh?

I can then start working on fixing traditional makefile and merging #26 since my block-pfaffian branch is using submodules extensively.

Thanks!

yomichi commented 3 years ago

I just update dist.sh to use git-archive-all in this branch.

xrq-phys commented 3 years ago

Excellent! I'll try moving StdFace and adjust CMakeLists.txt accordingly.

Thanks,

xrq-phys commented 3 years ago

I'm directly pushing the changes.

Please revert if any of you consider this inappropriate.

xrq-phys commented 3 years ago

Great job! Thanks!

and Sorry for the delay :D

xrq-phys commented 3 years ago

@tmisawa Added commit 2356343 (directly to tree/develop to address CI failure.

Will check also mVMCconfig.sh later.

tmisawa commented 3 years ago

@xrq-phys thank you!