search

issp-center-dev / mVMC

A numerical solver package for a wide range of quantum lattice models based on many-variable Variational Monte Carlo method
http://www.pasums.issp.u-tokyo.ac.jp/mvmc/en/
GNU General Public License v3.0
59 stars 19 forks source link

Fix workflow for macos target #59

Closed aoymt closed 2 months ago

aoymt commented 3 months ago

Fix the workflow script and the cmake config file to resolve CI failure in macos target

xrq-phys commented 2 months ago

CC @k-ido

Sorry for the long absense of reply.

Yeah in fact the download_blis_artifacts.cmake was a temporary solution to cope with the machines with no suitable BLIS binaries. Typically:

macOS indeed frequently introduces ABI compatibility changes, and now that Homebrew provides a decent BLIS build for macOS platforms. I think we can switch to Homebrew's BLIS build now.

Perhaps the only one that still depends on prebuild BLIS is Fugaku...

Anyways, this PR looks perfect to me. Let's hit the merge button and hopefully pipeline #57 can be automatically resolved.

And again, sorry for slowing the pace down...

k-ido commented 2 months ago

@xrq-phys Thank you for taking the time out of your busy schedule to check PRs related to the CI failure. Then for macOS, using Homebrew is a recommended way to install BLIS.