issuu / ocaml-protoc-plugin

ocaml-protoc-plugin
https://issuu.github.io/ocaml-protoc-plugin/
Other
48 stars 19 forks source link

Support importing from proto files with dash in their name #42

Closed AndreasDahl closed 1 year ago

andersfugmann commented 1 year ago

There might be a problem with name clashes. I'm not sure how protoc deals with special characters in the filename (which would be illegal in ocaml), but we might want to consider the trivial case of having both a-b.proto and a_b.proto - and even A-b.proto and other combinations. However I don't think this is a problem in real world so I will merge the PR.