Cleanup remaining bits from #28.

issuu / ocaml-protoc-plugin

ocaml-protoc-plugin

https://issuu.github.io/ocaml-protoc-plugin/

Other

48 stars 19 forks source link

Cleanup remaining bits from #28. #43

Closed andersfugmann closed 1 year ago

andersfugmann commented 1 year ago

This includes:

a fix for name clashes
use the actual name of the rpc endpoint for the name inside the module structure.
remove unused functions
revert unneeded changes
Move local scope handling to scope
Make emitted names in the service module more predicable. (the module will be the capitalized name of the service value)
Add tests for using reserved names

andersfugmann commented 1 year ago

@AndreasDahl, would you mind reviewing these changes. The current state of master needs this cleanup. It fixes as couple of things left from the initial PR(#28)

andersfugmann commented 1 year ago

@nymphium, I made a followup PR to address some of the remaining things on #28. Would you mind give it a look. Most importantly is that the name (endpoint string) is not mangled, and now reflects the endpoint name in the protobuf file.