search

issuu / ocaml-protoc-plugin

ocaml-protoc-plugin
https://issuu.github.io/ocaml-protoc-plugin/
Other
48 stars 19 forks source link

Add extra fields to RPC endpoints #50

Closed andersfugmann closed 1 year ago

andersfugmann commented 1 year ago

Add service_name, method_name and package_name to RPC modules.

Closes #49

andersfugmann commented 1 year ago

@AndreasDahl / @tmcgilchrist Could I get a review on the changes in this PR. The changes are relative small and strait forward. Apart from adding new fields to auto generated service structs, it slightly changes how the name field is constructed. I suggest reviewing all changes in one go (and not per commit).

andersfugmann commented 1 year ago

Thanks both. Really appreciated.

tmcgilchrist commented 1 year ago

Looks good to me. Thanks.

On Fri, 26 May 2023 at 7:47 pm, Anders Peter Fugmann < @.***> wrote:

Merged #50 https://github.com/issuu/ocaml-protoc-plugin/pull/50 into master.

— Reply to this email directly, view it on GitHub https://github.com/issuu/ocaml-protoc-plugin/pull/50#event-9348802312, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABJXOLYGA3RRHI6BNILVS3XIB3ZPANCNFSM6AAAAAAYMN2UC4 . You are receiving this because you were mentioned.Message ID: @.***>