search

ist-dresden / composum-nodes

Set of Apache Sling / AEM development tools: JCR browser, user and package management and more
https://www.composum.com/home/nodes.html
MIT License
55 stars 21 forks source link

Make sure we don't implement ProviderType classes #278

Closed royteeuwen closed 2 years ago

royteeuwen commented 2 years ago

@ist-rw I'm fixing Critical bugs reported by AEM Cloud Manager, namely to not implement ProviderType classes directly but use the wrappers. Could you check if this looks ok for you? I have not used the RemoteResolver yet so I'm not sure how to test this but seeing as all methods are overriden, nothing should be impacted

ist-rw commented 2 years ago

I'm not happy with such a change. I think it must be possible to implement a Resource if I implement a new ResourceProvider and a wrapper which isn't a wrapper and returns itself as wrapped resource is very dangerous and can cause an infinite loop.

royteeuwen commented 2 years ago

What about extending SyntheticResource instead?

ist-rw commented 2 years ago

An extension of a SyntheticResource might be an option and if I think about this it seems like a good option and represents a bit what the purpose of the RemoteResource is. That's good idea.

royteeuwen commented 2 years ago

@ist-rw done ;)

ist-rw commented 2 years ago

The release 4.0.1 is available now.