search

istanbuljs-archived-repos / istanbul-lib-instrument

deprecated, instead use https://github.com/istanbuljs/istanbuljs
Other
13 stars 13 forks source link

Direction in using new mode in 1.1.0-alpha.2 elsewhere? #12

Open dgsmith2 opened 8 years ago

dgsmith2 commented 8 years ago

Apologies for [a] being completely naive on the topics of calculating and applying coverage as well as [b] potentially asking this in the wrong forum.

I'm working with Typescript, which is being transpiled via webpack using awesome-typescript-loader. Showing coverage on the original *.ts files requires karma-remap-istanbul. However, it seems like it could/should be more native; plus my IDE (IntelliJ) only picks up on the coverage report from karma-coverage for the transpiled code, not the reported coverage from the remap.

I took a stab at updating istanbul-instrumenter-loader to 1.1.0-alpha.2, hoping it would quickly and easily fulfill my dreams: my changes. Sadly, it did not--coverage pertains to the transpiled code.

I'm unsure of where to continue fumbling around. It is to continue in the realm of the webpack loader? The karma-coverage instrumenter config? Both?

Thanks!

bcoe commented 7 years ago

@dgsmith2 I know this is something that @JaKXz has dealt with in the past there's an issue on nyc related to it:

https://github.com/istanbuljs/nyc/issues/176

There's also a blog post that someone was kind enough to have written:

http://rundef.com/typescript-code-coverage-istanbul-nyc

JaKXz commented 7 years ago

@dgsmith2 at first glance, you could try specifying istanbul-lib-instrument as the instrumenter in the karma config as it says for *.ts(x)? files... and then pass options to it. I just finished moving so I can take a closer look tomorrow - do you have a repo that I can look at? Or a minimal reproduction that matches your current config?

JaKXz commented 7 years ago

@dgsmith2 any luck so far? apologies for the late response, I just noticed that you posted this back in July! 😢

dgsmith2 commented 7 years ago

@JaKXz I had to move on, but currently trying to make some time to see if I can figure out where I was at the time and how I can potentially update things after reading through the linked resources.