search

istanbuljs / nyc

the Istanbul command line interface
https://istanbul.js.org/
ISC License
5.54k stars 353 forks source link

Update rimraf and glob #1565

Open danielbeeke opened 1 month ago

danielbeeke commented 1 month ago

Here is a pull request for updating the glob and rimraf version. I am trying to remove the deprecation warnings. Sorry for the previous pull request that one is only for glob.

bcoe commented 3 weeks ago

@danielbeeke thank you for the PR, things seem to mostly be working, but rimraf has a new error it's throwing on Windows:

throw Object.assign(new Error('Illegal characters in path.'), {

Anything jump out at you, for what might be causing this?

danielbeeke commented 3 weeks ago

It seems glob argument needs to be added for windows only.

See: https://github.com/isaacs/rimraf/issues/249

danielbeeke commented 2 weeks ago

Hi @bcoe would it be possible to run the CI again? I would love to see this resolved. If needed I can do more work on the code.

danielbeeke commented 1 week ago

Is there another maintainer that can help with the CI? It just needs to be triggered I think. I would love to remove the deprecated warning in my projects.

bcoe commented 1 week ago

Hey @danielbeeke still getting quite a few "not ok" errors with Windows.

If you can get it green I'll bump the deps.